Skip to content

KYLIN-4573 Add option to indicate whether to close file for every app…#1265

Merged
hit-lacus merged 1 commit intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-4573
Jun 16, 2020
Merged

KYLIN-4573 Add option to indicate whether to close file for every app…#1265
hit-lacus merged 1 commit intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-4573

Conversation

@kyotoYaho
Copy link

…end for Hive Producer

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

Codecov Report

Merging #1265 into master will decrease coverage by 0.29%.
The diff coverage is 13.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1265      +/-   ##
============================================
- Coverage     25.75%   25.45%   -0.30%     
- Complexity     6638     6733      +95     
============================================
  Files          1484     1505      +21     
  Lines         91202    93316    +2114     
  Branches      12727    13085     +358     
============================================
+ Hits          23487    23755     +268     
- Misses        65414    67221    +1807     
- Partials       2301     2340      +39     
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/kylin/common/KylinConfig.java 38.29% <0.00%> (-2.08%) 29.00 <0.00> (+1.00) ⬇️
.../java/org/apache/kylin/common/KylinConfigBase.java 12.68% <0.00%> (+1.02%) 51.00 <0.00> (+7.00)
...org/apache/kylin/common/restclient/RestClient.java 15.25% <0.00%> (-3.11%) 6.00 <1.00> (ø)
...n/java/org/apache/kylin/common/util/CheckUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/apache/kylin/cube/CubeSegment.java 42.27% <0.00%> (-6.25%) 65.00 <0.00> (ø)
...rg/apache/kylin/cube/gridtable/CubeCodeSystem.java 22.07% <0.00%> (-3.30%) 8.00 <0.00> (ø)
.../org/apache/kylin/cube/model/AggregationGroup.java 77.15% <ø> (ø) 85.00 <0.00> (ø)
...ain/java/org/apache/kylin/cube/model/CubeDesc.java 58.15% <0.00%> (-4.14%) 182.00 <0.00> (ø)
...va/org/apache/kylin/cube/model/DictionaryDesc.java 48.57% <0.00%> (-16.82%) 8.00 <0.00> (ø)
...apache/kylin/cube/model/HBaseColumnFamilyDesc.java 23.80% <0.00%> (-14.66%) 4.00 <0.00> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a65eb2...6168cc4. Read the comment docs.

@hit-lacus hit-lacus self-requested a review June 16, 2020 12:01
@hit-lacus
Copy link
Member

LGTM

@hit-lacus hit-lacus merged commit 616e066 into apache:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants