Skip to content

Correct grammar of message when there are no cubes#1441

Merged
hit-lacus merged 1 commit intoapache:masterfrom
AndrewLane:patch-1
Oct 10, 2020
Merged

Correct grammar of message when there are no cubes#1441
hit-lacus merged 1 commit intoapache:masterfrom
AndrewLane:patch-1

Conversation

@AndrewLane
Copy link

@AndrewLane AndrewLane commented Oct 9, 2020

Proposed changes

Grammar fix on message when there are no cubes.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6437

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 28.042%

Files with Coverage Reduction New Missed Lines %
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java 9 60.0%
Totals Coverage Status
Change from base Build 6416: -0.009%
Covered Lines: 26248
Relevant Lines: 93602

💛 - Coveralls

Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hit-lacus hit-lacus self-requested a review October 10, 2020 03:53
@hit-lacus hit-lacus merged commit 2a734f1 into apache:master Oct 10, 2020
@hit-lacus
Copy link
Member

Thank you @AndrewLane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants