Skip to content

Auto add USE $DATABASE; to the beginning of create_sample_tables.sql#1448

Merged
hit-lacus merged 1 commit intoapache:masterfrom
zhangayqian:KYLIN-4787
Oct 18, 2020
Merged

Auto add USE $DATABASE; to the beginning of create_sample_tables.sql#1448
hit-lacus merged 1 commit intoapache:masterfrom
zhangayqian:KYLIN-4787

Conversation

@zhangayqian
Copy link
Contributor

@zhangayqian zhangayqian commented Oct 14, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

coveralls commented Oct 14, 2020

Pull Request Test Coverage Report for Build 6457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 28.045%

Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 7 76.29%
Totals Coverage Status
Change from base Build 6452: -0.005%
Covered Lines: 26250
Relevant Lines: 93598

💛 - Coveralls

@zzcclp
Copy link
Contributor

zzcclp commented Oct 15, 2020

LGTM

Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hit-lacus hit-lacus merged commit c6200f9 into apache:master Oct 18, 2020
@hit-lacus
Copy link
Member

Thank you @zhangayqian .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments