Skip to content

[KYLIN-4827] Fix SparkMergingDictionary parallelize not work.#1488

Merged
shaofengshi merged 1 commit intoapache:masterfrom
Ted-Jiang:KYLIN-4827
Dec 31, 2020
Merged

[KYLIN-4827] Fix SparkMergingDictionary parallelize not work.#1488
shaofengshi merged 1 commit intoapache:masterfrom
Ted-Jiang:KYLIN-4827

Conversation

@Ted-Jiang
Copy link
Copy Markdown
Member

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6581

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.006%) to 28.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkMergingDictionary.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 81.58%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 79.07%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 78.12%
Totals Coverage Status
Change from base Build 6578: -0.006%
Covered Lines: 26253
Relevant Lines: 93618

💛 - Coveralls

@shaofengshi
Copy link
Copy Markdown
Contributor

How much performance improvement from this change? I'd like to know it. Thanks!

@Ted-Jiang
Copy link
Copy Markdown
Member Author

@shaofengshi In sample cube, merge two month data, did not seen any promote. But in production env it can fix GC job failed issue.

@shaofengshi
Copy link
Copy Markdown
Contributor

thanks Ted, it looks good to me!

@shaofengshi shaofengshi merged commit 9a3e5a3 into apache:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants