KYLIN-4826 fix kylin.source.hive.warehouse-dir can't found#1489
Merged
hit-lacus merged 2 commits intoapache:masterfrom Nov 30, 2020
wolfboys:master
Merged
KYLIN-4826 fix kylin.source.hive.warehouse-dir can't found#1489hit-lacus merged 2 commits intoapache:masterfrom wolfboys:master
hit-lacus merged 2 commits intoapache:masterfrom
wolfboys:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
============================================
- Coverage 25.51% 25.49% -0.03%
+ Complexity 6764 6763 -1
============================================
Files 1505 1505
Lines 93618 93621 +3
Branches 13111 13112 +1
============================================
- Hits 23884 23866 -18
- Misses 67357 67372 +15
- Partials 2377 2383 +6
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 6588
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
when using kylin 3.1.1's global dictionary, building the global dictionary failed because it could not be found "kylin.source.hive.warehouse-dir", resulting input path error.
After kylin is started for the first time, when it is started again, ${dir}/cached-hive-dependency.sh will be used, now " kylin.source.hive.warehouse-dir" is not in cached-hive- dependency.sh, the parameter is null, causing a bug
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...