KYLIN-4817 Refine CubeMigrationCLI for kylin4#1496
KYLIN-4817 Refine CubeMigrationCLI for kylin4#1496hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
Conversation
...ylin-spark-common/src/main/java/org/apache/kylin/engine/spark/metadata/cube/PathManager.java
Show resolved
Hide resolved
Test Evidence
|
Codecov Report
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1496 +/- ##
======================================================
Coverage ? 24.12%
Complexity ? 4611
======================================================
Files ? 1136
Lines ? 64388
Branches ? 9501
======================================================
Hits ? 15536
Misses ? 47240
Partials ? 1612 Continue to review full report at Codecov.
|
| } | ||
|
|
||
| public void checkMigrationSuccess(KylinConfig kylinConfig, String cubeName, Boolean ifFix) throws IOException { | ||
| CubeMigrationCheckCLI checkCLI = new CubeMigrationCheckCLI(kylinConfig, ifFix); |
There was a problem hiding this comment.
After remove HBase, looks like we do not need CubeMigrationCheckCLI any more.
| for (DictionaryDesc dictionaryDesc : cubeDesc.getDictionaries()) { | ||
| String[] columnInfo = dictionaryDesc.getColumnRef().getColumnWithTable().split("\\."); | ||
| String globalDictPath; | ||
| if (columnInfo.length == 3) { |
There was a problem hiding this comment.
In which case columnInfo.length is not 3?
hit-lacus
left a comment
There was a problem hiding this comment.
Approved.
Thank you for contribution. @zhangayqian


Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...