Skip to content

KYLIN-4741 Support to config the sparder application name#1521

Merged
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zzcclp:KYLIN-4741
Dec 23, 2020
Merged

KYLIN-4741 Support to config the sparder application name#1521
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zzcclp:KYLIN-4741

Conversation

@zzcclp
Copy link
Contributor

@zzcclp zzcclp commented Dec 22, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@zzcclp
Copy link
Contributor Author

zzcclp commented Dec 22, 2020

After setting 'kylin.query.sparder-context.app-name' to 'sparder_on_docker' and restart kylin instance, the name of sparder context is shown below:
image

image

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (kylin-on-parquet-v2@49dcdd2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1521   +/-   ##
======================================================
  Coverage                       ?   24.31%           
  Complexity                     ?     4619           
======================================================
  Files                          ?     1138           
  Lines                          ?    64439           
  Branches                       ?     9512           
======================================================
  Hits                           ?    15669           
  Misses                         ?    47134           
  Partials                       ?     1636           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dcdd2...8ece863. Read the comment docs.

Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hit-lacus hit-lacus merged commit 9b0cc69 into apache:kylin-on-parquet-v2 Dec 23, 2020
@zzcclp zzcclp deleted the KYLIN-4741 branch March 11, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants