Skip to content

KYLIN-4877 Use all dimension columns as sort columns when saving cuboid data#1547

Merged
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zzcclp:KYLIN-4877
Jan 19, 2021
Merged

KYLIN-4877 Use all dimension columns as sort columns when saving cuboid data#1547
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zzcclp:KYLIN-4877

Conversation

@zzcclp
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp commented Jan 18, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (kylin-on-parquet-v2@e719f7b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1547   +/-   ##
======================================================
  Coverage                       ?   24.27%           
  Complexity                     ?     4623           
======================================================
  Files                          ?     1144           
  Lines                          ?    65277           
  Branches                       ?     9584           
======================================================
  Hits                           ?    15845           
  Misses                         ?    47784           
  Partials                       ?     1648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e719f7b...adb8a42. Read the comment docs.

Copy link
Copy Markdown
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hit-lacus hit-lacus merged commit 588e08b into apache:kylin-on-parquet-v2 Jan 19, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (kylin-on-parquet-v2@e719f7b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rg/apache/kylin/engine/spark/job/CubeBuildJob.java 50.00% 1 Missing ⚠️
...rg/apache/kylin/engine/spark/job/CubeMergeJob.java 50.00% 1 Missing ⚠️
...apache/kylin/engine/spark/utils/Repartitioner.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1547   +/-   ##
======================================================
  Coverage                       ?   24.27%           
  Complexity                     ?     4623           
======================================================
  Files                          ?     1144           
  Lines                          ?    65277           
  Branches                       ?     9584           
======================================================
  Hits                           ?    15845           
  Misses                         ?    47784           
  Partials                       ?     1648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants