Skip to content

KYLIN-4906 Support query/job server dynamic register and discovery in kylin4#1585

Merged
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zhengshengjun:KYLIN-4906
Feb 22, 2021
Merged

KYLIN-4906 Support query/job server dynamic register and discovery in kylin4#1585
hit-lacus merged 1 commit intoapache:kylin-on-parquet-v2from
zhengshengjun:KYLIN-4906

Conversation

@zhengshengjun
Copy link
Copy Markdown
Member

… kylin4

(cherry picked from commit fa37255)
(cherry picked from commit fa37255)
(cherry picked from commit fa37255)

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (kylin-on-parquet-v2@b428f1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1585   +/-   ##
======================================================
  Coverage                       ?   24.36%           
  Complexity                     ?     4649           
======================================================
  Files                          ?     1145           
  Lines                          ?    65335           
  Branches                       ?     9595           
======================================================
  Hits                           ?    15917           
  Misses                         ?    47754           
  Partials                       ?     1664           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b428f1e...3f9dd29. Read the comment docs.

Comment thread core-common/pom.xml Outdated
<dependency>
<groupId>org.apache.curator</groupId>
<artifactId>curator-x-discovery</artifactId>
<!-- this jar was absent from hbase lib, so compile it -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be deleted. Because kylin4 is removing hbase dependency.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing

Copy link
Copy Markdown
Contributor

@zhangayqian zhangayqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… kylin4

(cherry picked from commit fa37255)
(cherry picked from commit fa37255)
(cherry picked from commit fa37255)
@hit-lacus hit-lacus added the Reviewing Reviewer is trying to review this patch. label Feb 20, 2021
@hit-lacus
Copy link
Copy Markdown
Member

This patch looks to me, will merge. Maybe we should update the offical document about JobScheduler, @zhangayqian could you please add a question and answer in https://cwiki.apache.org/confluence/display/KYLIN/FAQ+Kylin+4.X ?

Copy link
Copy Markdown
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hit-lacus hit-lacus merged commit 8a21389 into apache:kylin-on-parquet-v2 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewing Reviewer is trying to review this patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants