KYLIN-4906 Support query/job server dynamic register and discovery in kylin4#1585
Conversation
1c2c59a to
51f1ff5
Compare
Codecov Report
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1585 +/- ##
======================================================
Coverage ? 24.36%
Complexity ? 4649
======================================================
Files ? 1145
Lines ? 65335
Branches ? 9595
======================================================
Hits ? 15917
Misses ? 47754
Partials ? 1664 Continue to review full report at Codecov.
|
| <dependency> | ||
| <groupId>org.apache.curator</groupId> | ||
| <artifactId>curator-x-discovery</artifactId> | ||
| <!-- this jar was absent from hbase lib, so compile it --> |
There was a problem hiding this comment.
This comment can be deleted. Because kylin4 is removing hbase dependency.
There was a problem hiding this comment.
thanks for reviewing
51f1ff5 to
3f9dd29
Compare
|
This patch looks to me, will merge. Maybe we should update the offical document about JobScheduler, @zhangayqian could you please add a question and answer in https://cwiki.apache.org/confluence/display/KYLIN/FAQ+Kylin+4.X ? |
… kylin4
(cherry picked from commit fa37255)
(cherry picked from commit fa37255)
(cherry picked from commit fa37255)
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...