Skip to content

KYLIN-4908 Segment pruner support integer partition col in spark query engine#1588

Merged
hit-lacus merged 2 commits intoapache:kylin-on-parquet-v2from
zhengshengjun:KYLIN-4908
Mar 5, 2021
Merged

KYLIN-4908 Segment pruner support integer partition col in spark query engine#1588
hit-lacus merged 2 commits intoapache:kylin-on-parquet-v2from
zhengshengjun:KYLIN-4908

Conversation

@zhengshengjun
Copy link
Copy Markdown
Member

…y engine

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@zzcclp
Copy link
Copy Markdown
Contributor

zzcclp commented Feb 23, 2021

@zhengshengjun Please add a test case, for example, add a test case sql in kylin-it/src/test/resources/query/sql.

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (kylin-on-parquet-v2@b428f1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1588   +/-   ##
======================================================
  Coverage                       ?   24.35%           
  Complexity                     ?     4650           
======================================================
  Files                          ?     1145           
  Lines                          ?    65335           
  Branches                       ?     9595           
======================================================
  Hits                           ?    15912           
  Misses                         ?    47758           
  Partials                       ?     1665           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b428f1e...6ebc1fe. Read the comment docs.

@zzcclp
Copy link
Copy Markdown
Contributor

zzcclp commented Mar 2, 2021

@zhengshengjun Please rebase and resolve the conflict.

@zhengshengjun
Copy link
Copy Markdown
Member Author

@zhengshengjun Please rebase and resolve the conflict.
conflict resolved ~

@zzcclp
Copy link
Copy Markdown
Contributor

zzcclp commented Mar 2, 2021

LGTM

@hit-lacus hit-lacus merged commit de95ab9 into apache:kylin-on-parquet-v2 Mar 5, 2021
@codecov-commenter
Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants