KYLIN-5023 Support cluster deployMode for Standalone#1677
Merged
Conversation
Member
Author
Design Docroot cause and new design Chinese Basic Test CaseConfigurationEnable standaone cluster mode by following configuration. Log OutputKylin UI
|
Member
Author
Test CaseKill the Driver while the spark application is runningIt is clear that when Driver status is not the same as the spark application. |
Comment on lines
+70
to
+73
| val doNothing: PartialFunction[(String, String, Long), (String, String, Long)] = { | ||
| case x => x | ||
| } | ||
| val res: Iterable[(String, String, Long)] = cachedKylinJobMap.values.filter(app => app._1.contains(stepId)).collect(doNothing) |
Member
There was a problem hiding this comment.
hi, could these code be simplified to:
val res = cachedKylinJobMap.values.filter(_._1.contains(stepId))
Comment on lines
+88
to
+92
| var respJson = Map.empty[String, Any] | ||
| val tree = parseFull(responseStr) | ||
| respJson = tree match { | ||
| case Some(map: Map[String, Any]) => map | ||
| } |
Member
There was a problem hiding this comment.
maybe simplify to:
val respJson = parseFull(responseStr).get.asInstanceOf[Map[String, Any]]
|
Hi, @hit-lacus. Similar with #1682, compilation failed for Spark3 compatibility. To resolve the problem, L495 of KylinExpressions may be changed like the following: |
Member
Author
Thanks for let me know, thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Design doc
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.documentbranchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...