Skip to content

[KYLIN-5037] delete segment by UUID should disable the cube first#1692

Open
jimdn wants to merge 1 commit intoapache:kylin3from
jimdn:bugfix/delete-seg-by-uuid
Open

[KYLIN-5037] delete segment by UUID should disable the cube first#1692
jimdn wants to merge 1 commit intoapache:kylin3from
jimdn:bugfix/delete-seg-by-uuid

Conversation

@jimdn
Copy link
Copy Markdown

@jimdn jimdn commented Jul 16, 2021

Proposed changes

Kylin recently release v3.1.2 , add a new feature KYLIN-4938( delete segment by UUID), but the delete logic is not consistently with the Old logic:

  1. delete segment should disable the cube first
  2. check OrphonSegment when segment is not in READY status

This PR fix the problems above.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimdn
Copy link
Copy Markdown
Author

jimdn commented Jul 16, 2021

@jimdn jimdn changed the title delete segment should disable the cube first [KYLIN-5037] delete segment by UUID should disable the cube first Jul 16, 2021
Copy link
Copy Markdown
Contributor

@zhangayqian zhangayqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hit-lacus
Copy link
Copy Markdown
Member

Hi @Ted-Jiang , would you like to have a look?

@Ted-Jiang
Copy link
Copy Markdown
Member

This pr is design to delete some OrphonSegment which status is New and the cube status is enable.
If there are some errors happen when delete an OrphonSegment when cube is Enable, we should do this check.
@jimdn

@hit-lacus
Copy link
Copy Markdown
Member

Thanks @Ted-Jiang 's comment . Looks like there is some divergence in the design of this feature. Personally, I agreed with the @Ted-Jiang 's design, delete segment by UUID is a advanced feature for advanced admin which maybe not safe enough but provide some shortcut, user should recognize its risk. What do you think, @jimdn ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants