KYLIN-5097 modify hive dict table format from textfile to orc#1752
Closed
fengpod wants to merge 3 commits intoapache:kylin3from
Closed
KYLIN-5097 modify hive dict table format from textfile to orc#1752fengpod wants to merge 3 commits intoapache:kylin3from
fengpod wants to merge 3 commits intoapache:kylin3from
Conversation
Member
|
I am not quite not sure if I need to merge this patch since it is incompatible. I know some Kylin user write program to read and parse the dict tables's file to decode the Bitmap into original literal values. I wonder if this patch may break these user. |
Author
Compatible with the previous format, users can specify the table-format through configuration ‘kylin.dictionary.mr-hive.table.format’ 。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :
Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...