Skip to content

Comments

KYLIN-5097 modify hive dict table format from textfile to orc#1752

Closed
fengpod wants to merge 3 commits intoapache:kylin3from
fengpod:kylin3
Closed

KYLIN-5097 modify hive dict table format from textfile to orc#1752
fengpod wants to merge 3 commits intoapache:kylin3from
fengpod:kylin3

Conversation

@fengpod
Copy link

@fengpod fengpod commented Oct 12, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Github Branch

As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

  1. The original branch kylin-on-parquet-v2 for Kylin 4.X (Parquet Storage) has been renamed to branch main, and configured as the default branch;
  2. The original branch master for Kylin 3.X (HBase Storage) has been renamed to branch kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@fengpod fengpod changed the title modify hive dict table format from textfile to orc KYLIN-5097 modify hive dict table format from textfile to orc Oct 12, 2021
@hit-lacus
Copy link
Member

I am not quite not sure if I need to merge this patch since it is incompatible. I know some Kylin user write program to read and parse the dict tables's file to decode the Bitmap into original literal values. I wonder if this patch may break these user.

@fengpod
Copy link
Author

fengpod commented Nov 5, 2021

I am not quite not sure if I need to merge this patch since it is incompatible. I know some Kylin user write program to read and parse the dict tables's file to decode the Bitmap into original literal values. I wonder if this patch may break these user.

Compatible with the previous format, users can specify the table-format through configuration ‘kylin.dictionary.mr-hive.table.format’ 。

@fengpod fengpod deleted the branch apache:kylin3 December 8, 2021 03:04
@fengpod fengpod closed this Dec 8, 2021
@fengpod fengpod deleted the kylin3 branch December 8, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants