Skip to content

Conversation

@ian4hu
Copy link

@ian4hu ian4hu commented Jul 30, 2018

@asfgit
Copy link

asfgit commented Jul 30, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 3377

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 24.727%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 3376: 0.2%
Covered Lines: 15572
Relevant Lines: 62976

💛 - Coveralls

@ian4hu
Copy link
Author

ian4hu commented Jul 31, 2018

@shaofengshi Would you mind verifying this PR?

@shaofengshi
Copy link
Contributor

Thanks Hu! We will run the integration test for this PR; Thanks!

@shaofengshi
Copy link
Contributor

Compile and mvn test all good.

It looks good to me.

@liyang-gmt8 @rogercloud , please also take a review. Thanks!

@shaofengshi
Copy link
Contributor

Hi Ian, we need the commit message started with JIRA ID, for example: "KYLIN-3475 Make calcite connection configurable". Please update the commit message. You can do that with "git rebase -i HEAD~1" in your branch. After the commit message be updated, re-push to your fork, this PR will be automatically refreshed.

Thanks!

@ian4hu ian4hu changed the title feat(query): Make calcite connection is more configurable. #KYLIN-3475 KYLIN-3475 Make calcite connection is more configurable Aug 2, 2018
@ian4hu
Copy link
Author

ian4hu commented Aug 2, 2018

@liyang-gmt8 done.

@shaofengshi shaofengshi merged commit bccfb7f into apache:master Aug 2, 2018
Ted-Jiang added a commit to Ted-Jiang/kylin that referenced this pull request Jun 2, 2021
* [EBAY-KYLIN-2677] Add prometheus push gateway to push system monitoring metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants