[KYLIN-4382] Unable to use DATE type in prepared statements#1809
[KYLIN-4382] Unable to use DATE type in prepared statements#1809juntaozhang wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
=======================================
Coverage ? 24.60%
Complexity ? 4437
=======================================
Files ? 1095
Lines ? 61855
Branches ? 8866
=======================================
Hits ? 15220
Misses ? 45026
Partials ? 1609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } else { | ||
| value = String.valueOf(DateFormat.stringToMillis(value)); | ||
| } | ||
| logger.debug("value changed after: {}", value); |
There was a problem hiding this comment.
Could you please combine two lines into one line, like : Column value changed from {} to {}.
|
Hi @juntaozhang, I tested this PR, which can fix the bug on kylin3, but it doesn't work on kylin4. I think this PR should be merged into |
Thanks for your reply, do you means I should merge to branch/kylin3? Need I create a new PR? |
Yes, you can create a new PR to |
Proposed changes
fix KYLIN-4382 Unable to use DATE type in prepared statements
Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :
Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...