Skip to content

[KYLIN-4382] Unable to use DATE type in prepared statements#1809

Closed
juntaozhang wants to merge 3 commits into
apache:mainfrom
juntaozhang:KYLIN-4382
Closed

[KYLIN-4382] Unable to use DATE type in prepared statements#1809
juntaozhang wants to merge 3 commits into
apache:mainfrom
juntaozhang:KYLIN-4382

Conversation

@juntaozhang
Copy link
Copy Markdown

Proposed changes

fix KYLIN-4382 Unable to use DATE type in prepared statements

Github Branch

As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

  1. The original branch kylin-on-parquet-v2 for Kylin 4.X (Parquet Storage) has been renamed to branch main, and configured as the default branch;
  2. The original branch master for Kylin 3.X (HBase Storage) has been renamed to branch kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2022

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@8365e66). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...va/org/apache/kylin/query/relnode/OLAPContext.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1809   +/-   ##
=======================================
  Coverage        ?   24.60%           
  Complexity      ?     4437           
=======================================
  Files           ?     1095           
  Lines           ?    61855           
  Branches        ?     8866           
=======================================
  Hits            ?    15220           
  Misses          ?    45026           
  Partials        ?     1609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

} else {
value = String.valueOf(DateFormat.stringToMillis(value));
}
logger.debug("value changed after: {}", value);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please combine two lines into one line, like : Column value changed from {} to {}.

@zhangayqian
Copy link
Copy Markdown
Contributor

Hi @juntaozhang, I tested this PR, which can fix the bug on kylin3, but it doesn't work on kylin4. I think this PR should be merged into kylin3 branch.

Comment thread jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
@juntaozhang
Copy link
Copy Markdown
Author

Hi @juntaozhang, I tested this PR, which can fix the bug on kylin3, but it doesn't work on kylin4. I think this PR should be merged into kylin3 branch.

Thanks for your reply, do you means I should merge to branch/kylin3? Need I create a new PR?

@zhangayqian
Copy link
Copy Markdown
Contributor

Hi @juntaozhang, I tested this PR, which can fix the bug on kylin3, but it doesn't work on kylin4. I think this PR should be merged into kylin3 branch.

Thanks for your reply, do you means I should merge to branch/kylin3? Need I create a new PR?

Yes, you can create a new PR to kylin3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants