Skip to content

improve performance of getInstanceFromEnv#1994

Merged
hit-lacus merged 1 commit intoapache:mainfrom
liuzhao-lz:improve
Oct 14, 2022
Merged

improve performance of getInstanceFromEnv#1994
hit-lacus merged 1 commit intoapache:mainfrom
liuzhao-lz:improve

Conversation

@liuzhao-lz
Copy link

Proposed changes

Improve performance of getInstanceFromEnv to avoid unnecessary synchronization

Branch to commit

  • Branch kylin3 for v2.x to v3.x
  • Branch kylin4 for v4.x
  • Branch kylin5 for v5.x

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...


// static cached instances
private static KylinConfig SYS_ENV_INSTANCE = null;
private static volatile KylinConfig SYS_ENV_INSTANCE = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need add volatile here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非 volatile 变量的读取会从主存拷到寄存器,thread1 & thread2 进入 sychronized 前SYS_ENV_INSTANCE被拷贝到各自的寄存器,假如 thread2 先执行了 sychronized 内的代码,thread2执行完后 thread1 由于SYS_ENV_INSTANCE 拷贝到寄存器,第二次判空可能结果为 true,就会再一次执行 sychronized 内的代码

@hit-lacus
Copy link
Member

LGTM

@hit-lacus hit-lacus merged commit e603ecf into apache:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants