improve performance of getInstanceFromEnv#1994
Merged
hit-lacus merged 1 commit intoapache:mainfrom Oct 14, 2022
Merged
Conversation
hit-lacus
reviewed
Oct 11, 2022
|
|
||
| // static cached instances | ||
| private static KylinConfig SYS_ENV_INSTANCE = null; | ||
| private static volatile KylinConfig SYS_ENV_INSTANCE = null; |
Author
There was a problem hiding this comment.
非 volatile 变量的读取会从主存拷到寄存器,thread1 & thread2 进入 sychronized 前SYS_ENV_INSTANCE被拷贝到各自的寄存器,假如 thread2 先执行了 sychronized 内的代码,thread2执行完后 thread1 由于SYS_ENV_INSTANCE 拷贝到寄存器,第二次判空可能结果为 true,就会再一次执行 sychronized 内的代码
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve performance of getInstanceFromEnv to avoid unnecessary synchronization
Branch to commit
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...