Skip to content

KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby#2006

Merged
hit-lacus merged 1 commit intoapache:mainfrom
liuzhao-lz:KYLIN-5285
Nov 2, 2022
Merged

KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby#2006
hit-lacus merged 1 commit intoapache:mainfrom
liuzhao-lz:KYLIN-5285

Conversation

@liuzhao-lz
Copy link

@liuzhao-lz liuzhao-lz commented Oct 31, 2022

Proposed changes

当查询满足shardby条件,在创建 FileScanRDD 时,FilePartition 数应由 shardby 裁剪后的数据文件确定,而不是由回答当前查询的cuboid下所有文件确定。

before apply patch:
75f05254505233fb607cb082a6c5331
6ad28bbbf6185896ebebaba241c2c44
753a890c47adf4b5d2dd045acf16688

after apply patch:
6668ce58d0fd4bfad491e855e8ba196
79590990a30b061f57174306968d6d3
ccff12e72b968071b0565ad74178b06

Branch to commit

  • Branch kylin3 for v2.x to v3.x
  • Branch kylin4 for v4.x
  • Branch kylin5 for v5.x

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hit-lacus
Copy link
Member

Can one of the admins verify this patch?

@liuzhao-lz liuzhao-lz closed this Oct 31, 2022
KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby
Copy link
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this patch looks good to me.

@hit-lacus hit-lacus merged commit 35e1487 into apache:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants