KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby#2006
Merged
hit-lacus merged 1 commit intoapache:mainfrom Nov 2, 2022
Merged
KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby#2006hit-lacus merged 1 commit intoapache:mainfrom
hit-lacus merged 1 commit intoapache:mainfrom
Conversation
Member
|
Can one of the admins verify this patch? |
KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby
aeb933c to
b65e5a0
Compare
hit-lacus
approved these changes
Nov 2, 2022
Member
hit-lacus
left a comment
There was a problem hiding this comment.
Thanks, this patch looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
当查询满足shardby条件,在创建 FileScanRDD 时,FilePartition 数应由 shardby 裁剪后的数据文件确定,而不是由回答当前查询的cuboid下所有文件确定。
before apply patch:



after apply patch:



Branch to commit
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...