Skip to content

Apache kylin 2895 updated#299

Merged
shaofengshi merged 12 commits intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-2895-updated
Oct 29, 2018
Merged

Apache kylin 2895 updated#299
shaofengshi merged 12 commits intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-2895-updated

Conversation

@kyotoYaho
Copy link

No description provided.

@asfgit
Copy link

asfgit commented Oct 19, 2018

Can one of the admins verify this patch?

@kyotoYaho kyotoYaho force-pushed the APACHE-KYLIN-2895-updated branch from 589207b to c14b083 Compare October 19, 2018 03:47
@kyotoYaho kyotoYaho force-pushed the APACHE-KYLIN-2895-updated branch from c14b083 to 4455be9 Compare October 23, 2018 12:21
@kyotoYaho kyotoYaho force-pushed the APACHE-KYLIN-2895-updated branch from 4455be9 to b2e0f0e Compare October 24, 2018 02:34
@codecov-io
Copy link

Codecov Report

Merging #299 into master will increase coverage by 0.25%.
The diff coverage is 34.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
+ Coverage     21.31%   21.57%   +0.25%     
- Complexity     4448     4580     +132     
============================================
  Files          1089     1111      +22     
  Lines         69996    71151    +1155     
  Branches      10098    10281     +183     
============================================
+ Hits          14922    15353     +431     
- Misses        53671    54326     +655     
- Partials       1403     1472      +69
Impacted Files Coverage Δ Complexity Δ
...pache/kylin/cache/cachemanager/CacheConstants.java 0% <0%> (ø) 0 <0> (?)
.../java/org/apache/kylin/common/KylinConfigBase.java 14.39% <0%> (-0.25%) 36 <0> (ø)
.../kylin/cache/ehcache/InstrumentedEhCacheCache.java 0% <0%> (ø) 0 <0> (?)
...org/apache/kylin/common/debug/BackdoorToggles.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/apache/kylin/rest/service/QueryService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/kylin/cache/memcached/CacheStats.java 0% <0%> (ø) 0 <0> (?)
...in/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/kylin/cache/memcached/MemcachedMetrics.java 0% <0%> (ø) 0 <0> (?)
...kylin/storage/hbase/cube/v2/SegmentQueryCache.java 0% <0%> (ø) 0 <0> (?)
...ain/java/org/apache/kylin/common/QueryContext.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b51d4a...b2e0f0e. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3802

  • 484 of 1201 (40.3%) changed or added relevant lines in 29 files are covered.
  • 9 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 23.65%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cache/src/main/java/org/apache/kylin/cache/cachemanager/CacheConstants.java 0 1 0.0%
cache/src/main/java/org/apache/kylin/cache/cachemanager/RemoteLocalFailOverCacheManager.java 12 13 92.31%
core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java 0 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/response/SQLResponse.java 7 8 87.5%
server-base/src/main/java/org/apache/kylin/rest/signature/SegmentSignature.java 17 18 94.44%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/SegmentQueryResult.java 28 29 96.55%
cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedConnectionFactoryBuilder.java 25 28 89.29%
server-base/src/main/java/org/apache/kylin/rest/service/CacheService.java 0 4 0.0%
server-base/src/main/java/org/apache/kylin/rest/signature/RealizationSetCalculator.java 28 34 82.35%
cache/src/main/java/org/apache/kylin/cache/memcached/MemcachedCacheConfig.java 20 28 71.43%
Files with Coverage Reduction New Missed Lines %
core-common/src/main/java/org/apache/kylin/common/QueryContext.java 1 0.0%
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java 1 0.0%
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 3 78.42%
server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java 3 0.0%
Totals Coverage Status
Change from base Build 3801: 0.3%
Covered Lines: 16827
Relevant Lines: 71151

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks Yanghong and the team!

@shaofengshi shaofengshi merged commit de86ed6 into apache:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants