Skip to content

Conversation

@Aaaaaaron
Copy link
Member

No description provided.

@asfgit
Copy link

asfgit commented Oct 28, 2018

Can one of the admins verify this patch?

@Aaaaaaron
Copy link
Member Author

Hi Shaofeng, I see this patch has been merged into branch 2.4/2.5, should we merge this into mater?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3817

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 23.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java 0 4 0.0%
server-base/src/main/java/org/apache/kylin/rest/security/ManagedUser.java 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java 2 0.0%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 3815: 0.003%
Covered Lines: 16316
Relevant Lines: 70011

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 3bcbaa8 into apache:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants