Skip to content

Fix issue : KYLIN-3631#350

Merged
shaofengshi merged 1 commit intoapache:masterfrom
whuwb:issue_3631_wubin
Nov 20, 2018
Merged

Fix issue : KYLIN-3631#350
shaofengshi merged 1 commit intoapache:masterfrom
whuwb:issue_3631_wubin

Conversation

@whuwb
Copy link

@whuwb whuwb commented Nov 19, 2018

Issue : https://issues.apache.org/jira/browse/KYLIN-3631
How to fix :

  1. Find all the Arrays.sort and replace with Arrays.parallelSort and add comments.
  2. Run UT & integration tests to validate the fix.

@asfgit
Copy link

asfgit commented Nov 19, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Nov 19, 2018

Pull Request Test Coverage Report for Build 3860

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 25.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 78.12%
Totals Coverage Status
Change from base Build 3853: -0.003%
Covered Lines: 17645
Relevant Lines: 68093

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #350 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #350      +/-   ##
============================================
- Coverage     23.62%   23.61%   -0.01%     
+ Complexity     4823     4822       -1     
============================================
  Files          1133     1133              
  Lines         68093    68093              
  Branches       9657     9657              
============================================
- Hits          16087    16081       -6     
- Misses        50445    50449       +4     
- Partials       1561     1563       +2
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/kylin/metadata/model/Segments.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/kylin/metadata/model/TableDesc.java 47.77% <100%> (ø) 27 <0> (ø) ⬇️
...g/apache/kylin/source/datagen/ColumnGenerator.java 70.94% <0%> (-1.36%) 8% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0%> (-0.92%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6344986...c47dd9f. Read the comment docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not needed. Can you remove it in all the places?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Bin!

@shaofengshi shaofengshi merged commit dca3ee7 into apache:master Nov 20, 2018
@whuwb whuwb deleted the issue_3631_wubin branch November 20, 2018 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments