Merged
Conversation
|
Can one of the admins verify this patch? |
Pull Request Test Coverage Report for Build 3860
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
============================================
- Coverage 23.62% 23.61% -0.01%
+ Complexity 4823 4822 -1
============================================
Files 1133 1133
Lines 68093 68093
Branches 9657 9657
============================================
- Hits 16087 16081 -6
- Misses 50445 50449 +4
- Partials 1561 1563 +2
Continue to review full report at Codecov.
|
shaofengshi
reviewed
Nov 19, 2018
Contributor
There was a problem hiding this comment.
This comment is not needed. Can you remove it in all the places?
6d746ab to
88492db
Compare
shaofengshi
approved these changes
Nov 20, 2018
Contributor
shaofengshi
left a comment
There was a problem hiding this comment.
LGTM, thank you Bin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : https://issues.apache.org/jira/browse/KYLIN-3631
How to fix :