Skip to content

KYLIN-3697 Check port availability when starts kylin instance#353

Merged
shaofengshi merged 1 commit intoapache:masterfrom
DingqianZhou:KYLIN-3697
Nov 20, 2018
Merged

KYLIN-3697 Check port availability when starts kylin instance#353
shaofengshi merged 1 commit intoapache:masterfrom
DingqianZhou:KYLIN-3697

Conversation

@DingqianZhou
Copy link
Copy Markdown

No description provided.

@asfgit
Copy link
Copy Markdown

asfgit commented Nov 20, 2018

Can one of the admins verify this patch?

Copy link
Copy Markdown
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 5aea3d4 into apache:master Nov 20, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #353 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #353      +/-   ##
============================================
+ Coverage      23.6%   23.61%   +<.01%     
- Complexity     4824     4825       +1     
============================================
  Files          1133     1133              
  Lines         68102    68102              
  Branches       9659     9659              
============================================
+ Hits          16077    16080       +3     
+ Misses        50458    50457       -1     
+ Partials       1567     1565       -2
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/kylin/cube/model/CubeDesc.java 64.28% <0%> (ø) 179% <0%> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0%> (+0.6%) 7% <0%> (ø) ⬇️
...a/org/apache/kylin/dict/Number2BytesConverter.java 82.53% <0%> (+0.79%) 18% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e03407...28d1427. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants