Skip to content

KYLIN-3724 Kylin IT test sql is unreasonable#402

Merged
shaofengshi merged 1 commit intoapache:masterfrom
hit-lacus:KYLIN-3724
Dec 23, 2018
Merged

KYLIN-3724 Kylin IT test sql is unreasonable#402
shaofengshi merged 1 commit intoapache:masterfrom
hit-lacus:KYLIN-3724

Conversation

@hit-lacus
Copy link
Member

@hit-lacus hit-lacus commented Dec 18, 2018 •
edited
Loading

local ci test pass

@asfgit
Copy link

asfgit commented Dec 18, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Dec 18, 2018

Pull Request Test Coverage Report for Build 3979

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 25.799%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 3977: -0.001%
Covered Lines: 17820
Relevant Lines: 69073
💛 - Coveralls

shaofengshi
shaofengshi approved these changes Dec 23, 2018
View reviewed changes
Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 9bf0063 into apache:master Dec 23, 2018
@hit-lacus hit-lacus deleted the KYLIN-3724 branch August 15, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaofengshi shaofengshi shaofengshi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hit-lacus @asfgit @coveralls @shaofengshi