Skip to content

KYLIN-3597 fix sonar issues#444

Merged
shaofengshi merged 1 commit intoapache:masterfrom
whuwb:issue_3597_wubin
Jan 24, 2019
Merged

KYLIN-3597 fix sonar issues#444
shaofengshi merged 1 commit intoapache:masterfrom
whuwb:issue_3597_wubin

Conversation

@whuwb
Copy link
Copy Markdown

@whuwb whuwb commented Jan 23, 2019

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT:
[INFO]
[INFO] Apache Kylin ....................................... SUCCESS [ 6.974 s]
[INFO] Apache Kylin - Core Common ......................... SUCCESS [ 17.837 s]
[INFO] Apache Kylin - Core Metadata ....................... SUCCESS [ 53.416 s]
[INFO] Apache Kylin - Core Dictionary ..................... SUCCESS [06:03 min]
[INFO] Apache Kylin - Core Cube ........................... SUCCESS [01:24 min]
[INFO] Apache Kylin - Core Metrics ........................ SUCCESS [ 1.493 s]
[INFO] Apache Kylin - Core Job ............................ SUCCESS [ 46.899 s]
[INFO] Apache Kylin - Core Storage ........................ SUCCESS [ 8.040 s]
[INFO] Apache Kylin - MapReduce Engine .................... SUCCESS [ 22.222 s]
[INFO] Apache Kylin - Spark Engine ........................ SUCCESS [ 15.364 s]
[INFO] Apache Kylin - Hive Source ......................... SUCCESS [ 7.214 s]
[INFO] Apache Kylin - DataSource SDK ...................... SUCCESS [ 10.493 s]
[INFO] Apache Kylin - Jdbc Source ......................... SUCCESS [ 20.402 s]
[INFO] Apache Kylin - Kafka Source ........................ SUCCESS [ 4.901 s]
[INFO] Apache Kylin - Cache ............................... SUCCESS [ 7.958 s]
[INFO] Apache Kylin - HBase Storage ....................... SUCCESS [ 41.641 s]
[INFO] Apache Kylin - Query ............................... SUCCESS [ 11.846 s]
[INFO] Apache Kylin - Metrics Reporter Hive ............... SUCCESS [ 1.031 s]
[INFO] Apache Kylin - Metrics Reporter Kafka .............. SUCCESS [ 1.359 s]
[INFO] Apache Kylin - REST Server Base .................... SUCCESS [ 27.610 s]
[INFO] Apache Kylin - REST Server ......................... SUCCESS [01:50 min]
[INFO] Apache Kylin - JDBC Driver ......................... SUCCESS [ 9.361 s]
[INFO] Apache Kylin - Assembly ............................ SUCCESS [ 15.579 s]
[INFO] Apache Kylin - Tool ................................ SUCCESS [ 16.280 s]
[INFO] Apache Kylin - Tool Assembly ....................... SUCCESS [ 5.683 s]
[INFO] Apache Kylin - Integration Test .................... SUCCESS [ 02:42 h]
[INFO] Apache Kylin - Tomcat Extension .................... SUCCESS [ 4.301 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:58 h
[INFO] Finished at: 2019-01-23T09:55:58Z
[INFO] ------------------------------------------------------------------------

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@168fa86). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #444   +/-   ##
=========================================
  Coverage          ?   24.36%           
  Complexity        ?     4940           
=========================================
  Files             ?     1143           
  Lines             ?    69376           
  Branches          ?     9889           
=========================================
  Hits              ?    16905           
  Misses            ?    50764           
  Partials          ?     1707
Impacted Files Coverage Δ Complexity Δ
.../kylin/engine/mr/common/CuboidRecommenderUtil.java 0% <0%> (ø) 0 <0> (?)
...kylin/cube/cuboid/algorithm/CuboidRecommender.java 0% <0%> (ø) 0 <0> (?)
...ache/kylin/engine/mr/steps/SaveStatisticsStep.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168fa86...b03a87e. Read the comment docs.

@asfgit
Copy link
Copy Markdown

asfgit commented Jan 23, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link
Copy Markdown

asfgit commented Jan 23, 2019

Can one of the admins verify this patch?

Copy link
Copy Markdown
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit d3235e7 into apache:master Jan 24, 2019
@whuwb whuwb deleted the issue_3597_wubin branch January 24, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants