Skip to content

KYLIN-3851 Flink cubing step : merge dictionary#540

Merged
shaofengshi merged 1 commit intoapache:engine-flinkfrom
yanghua:KYLIN-3851
Mar 21, 2019
Merged

KYLIN-3851 Flink cubing step : merge dictionary#540
shaofengshi merged 1 commit intoapache:engine-flinkfrom
yanghua:KYLIN-3851

Conversation

@yanghua
Copy link
Copy Markdown

@yanghua yanghua commented Mar 20, 2019

@asfgit
Copy link
Copy Markdown

asfgit commented Mar 20, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link
Copy Markdown

asfgit commented Mar 20, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (engine-flink@ea34ffc). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##             engine-flink     #540   +/-   ##
===============================================
  Coverage                ?   24.14%           
  Complexity              ?     5029           
===============================================
  Files                   ?     1173           
  Lines                   ?    71300           
  Branches                ?    10111           
===============================================
  Hits                    ?    17215           
  Misses                  ?    52345           
  Partials                ?     1740
Impacted Files Coverage Δ Complexity Δ
...he/kylin/engine/mr/steps/UpdateDictionaryStep.java 0% <0%> (ø) 0 <0> (?)
...kylin/engine/flink/FlinkBatchMergeJobBuilder2.java 0% <0%> (ø) 0 <0> (?)
...che/kylin/engine/flink/FlinkMergingDictionary.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea34ffc...48e1bdd. Read the comment docs.

Copy link
Copy Markdown
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 4f04060 into apache:engine-flink Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants