Skip to content

KYLIN-3919 Add unit test for FlinkOnYarnConfigMapping#566

Merged
shaofengshi merged 1 commit intoapache:engine-flinkfrom
yanghua:KYLIN-3919
Mar 29, 2019
Merged

KYLIN-3919 Add unit test for FlinkOnYarnConfigMapping#566
shaofengshi merged 1 commit intoapache:engine-flinkfrom
yanghua:KYLIN-3919

Conversation

@yanghua
Copy link
Copy Markdown

@yanghua yanghua commented Mar 28, 2019

@asfgit
Copy link
Copy Markdown

asfgit commented Mar 28, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link
Copy Markdown

asfgit commented Mar 28, 2019

Can one of the admins verify this patch?

@yanghua
Copy link
Copy Markdown
Author

yanghua commented Mar 28, 2019

cc @shaofengshi

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (engine-flink@99eaa8a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             engine-flink     #566   +/-   ##
===============================================
  Coverage                ?   24.14%           
  Complexity              ?     5031           
===============================================
  Files                   ?     1173           
  Lines                   ?    71300           
  Branches                ?    10111           
===============================================
  Hits                    ?    17215           
  Misses                  ?    52339           
  Partials                ?     1746

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99eaa8a...3943e46. Read the comment docs.

Copy link
Copy Markdown
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 8ffa636 into apache:engine-flink Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants