Skip to content

KYLIN-3946 Fix count column compatibility#593

Merged
nichunen merged 1 commit intoapache:masterfrom
Wayne1c:KYLIN-3946
Apr 11, 2019
Merged

KYLIN-3946 Fix count column compatibility#593
nichunen merged 1 commit intoapache:masterfrom
Wayne1c:KYLIN-3946

Conversation

@Wayne1c
Copy link
Copy Markdown

@Wayne1c Wayne1c commented Apr 11, 2019

No description provided.

@asfgit
Copy link
Copy Markdown

asfgit commented Apr 11, 2019

Can one of the admins verify this patch?

2 similar comments
@asfgit
Copy link
Copy Markdown

asfgit commented Apr 11, 2019

Can one of the admins verify this patch?

@asfgit
Copy link
Copy Markdown

asfgit commented Apr 11, 2019

Can one of the admins verify this patch?

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4378

  • 0 of 15 (0.0%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 27.717%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java 0 4 0.0%
query/src/main/java/org/apache/kylin/query/relnode/OLAPAggregateRel.java 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
query/src/main/java/org/apache/kylin/query/relnode/OLAPAggregateRel.java 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 2 55.81%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 4377: -0.01%
Covered Lines: 22640
Relevant Lines: 81682

💛 - Coveralls

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #593 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #593      +/-   ##
============================================
- Coverage     25.25%   25.24%   -0.02%     
+ Complexity     5811     5810       -1     
============================================
  Files          1379     1379              
  Lines         81669    81682      +13     
  Branches      11436    11441       +5     
============================================
- Hits          20628    20619       -9     
- Misses        59027    59046      +19     
- Partials       2014     2017       +3
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/kylin/cube/CubeCapabilityChecker.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/apache/kylin/query/relnode/OLAPAggregateRel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
...ream/core/storage/columnar/ColumnarStoreCache.java 48.83% <0%> (-3.49%) 7% <0%> (ø)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 78.37% <0%> (+5.4%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc51f3...ef8f5b7. Read the comment docs.

Copy link
Copy Markdown

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 7deb204 into apache:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants