Skip to content

#3926, set sourceRecordCount when updating statistics#626

Closed
yuexingri wants to merge 2 commits intoapache:masterfrom
yuexingri:APACHE-KYLIN-3926
Closed

#3926, set sourceRecordCount when updating statistics#626
yuexingri wants to merge 2 commits intoapache:masterfrom
yuexingri:APACHE-KYLIN-3926

Conversation

@yuexingri
Copy link
Copy Markdown

rt

@asfgit
Copy link
Copy Markdown

asfgit commented May 3, 2019

Can one of the admins verify this patch?

@coveralls
Copy link
Copy Markdown

coveralls commented May 3, 2019

Pull Request Test Coverage Report for Build 4447

  • 0 of 15 (0.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 27.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/CubeStatsReader.java 0 1 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsWithOldStep.java 0 1 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/CubeStatsWriter.java 0 2 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 78.12%
Totals Coverage Status
Change from base Build 4445: -0.005%
Covered Lines: 22801
Relevant Lines: 81822

💛 - Coveralls

@yuexingri
Copy link
Copy Markdown
Author

retest this please

@shaofengshi
Copy link
Copy Markdown
Contributor

duplicated with #579

@yuexingri yuexingri force-pushed the APACHE-KYLIN-3926 branch from 425c9f3 to 5c727c1 Compare May 5, 2019 01:22
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #626 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #626      +/-   ##
============================================
- Coverage     25.39%   25.39%   -0.01%     
+ Complexity     5865     5864       -1     
============================================
  Files          1379     1379              
  Lines         81808    81822      +14     
  Branches      11465    11468       +3     
============================================
- Hits          20777    20776       -1     
- Misses        59011    59025      +14     
- Partials       2020     2021       +1
Impacted Files Coverage Δ Complexity Δ
...in/engine/mr/steps/MergeStatisticsWithOldStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/kylin/engine/mr/common/CubeStatsWriter.java 58.62% <0%> (-4.35%) 3 <0> (ø)
...che/kylin/engine/mr/steps/MergeStatisticsStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/kylin/engine/mr/common/CubeStatsReader.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (+0.3%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2076e39...5c727c1. Read the comment docs.

@nichunen
Copy link
Copy Markdown

nichunen commented May 7, 2019

duplicated with #579, close it

@nichunen nichunen closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants