Skip to content

KYLIN-3983 Add extra metadata for measure. Add test case and example/…#638

Merged
nichunen merged 1 commit intoapache:dynamic-measurefrom
Qsimple:origin_dynamic_measure
May 14, 2019
Merged

KYLIN-3983 Add extra metadata for measure. Add test case and example/…#638
nichunen merged 1 commit intoapache:dynamic-measurefrom
Qsimple:origin_dynamic_measure

Conversation

@Qsimple
Copy link

@Qsimple Qsimple commented May 13, 2019

…test_case_data for MeasureManager. Add measure metadata in sample cube

UT passed

IT passed

rewrite some logic according to the advices from #629

…test_case_data for MeasureManager. Add measure metadata in sample cube
@asfgit
Copy link

asfgit commented May 13, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #638 into dynamic-measure will increase coverage by 0.39%.
The diff coverage is 66.91%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             dynamic-measure     #638      +/-   ##
=====================================================
+ Coverage              25.48%   25.87%   +0.39%     
- Complexity              5892     6062     +170     
=====================================================
  Files                   1379     1386       +7     
  Lines                  81871    82544     +673     
  Branches               11479    11559      +80     
=====================================================
+ Hits                   20863    21359     +496     
- Misses                 58986    59131     +145     
- Partials                2022     2054      +32
Impacted Files Coverage Δ Complexity Δ
...apache/kylin/common/persistence/ResourceStore.java 66.9% <ø> (ø) 45 <0> (ø) ⬇️
...org/apache/kylin/metadata/model/DateTimeRange.java 0% <0%> (ø) 0 <0> (?)
...e/kylin/cube/adapter/OneCFHBaseMappingAdapter.java 0% <0%> (ø) 0 <0> (?)
.../apache/kylin/common/persistence/ResourceTool.java 21.96% <0%> (-0.13%) 14 <0> (ø)
.../java/org/apache/kylin/common/KylinConfigBase.java 12.9% <0%> (-0.15%) 42 <0> (ø)
...c/main/java/org/apache/kylin/cube/CubeManager.java 40.32% <100%> (+2.55%) 50 <1> (+6) ⬆️
...in/java/org/apache/kylin/cube/CubeDescManager.java 47.14% <100%> (+13.32%) 14 <0> (+2) ⬆️
.../java/org/apache/kylin/measure/MeasureManager.java 62.58% <62.58%> (ø) 68 <68> (?)
...ylin/cube/adapter/AbstractHBaseMappingAdapter.java 68.88% <68.88%> (ø) 21 <21> (?)
.../cube/adapter/MemoryHungryHBaseMappingAdapter.java 70.37% <70.37%> (ø) 6 <6> (?)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39b238...4b639da. Read the comment docs.

@nichunen nichunen self-requested a review May 13, 2019 06:03
Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 5ebcee6 into apache:dynamic-measure May 14, 2019
@Qsimple Qsimple deleted the origin_dynamic_measure branch May 14, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants