Skip to content

Comments

Add unit tests three#639

Merged
nichunen merged 3 commits intoapache:masterfrom
TheRealHaui:add-Unit-Tests-three
May 14, 2019
Merged

Add unit tests three#639
nichunen merged 3 commits intoapache:masterfrom
TheRealHaui:add-Unit-Tests-three

Conversation

@TheRealHaui
Copy link

Added additional Unit Tests to increase code coverage.

@asfgit
Copy link

asfgit commented May 13, 2019

Can one of the admins verify this patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4490

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 27.984%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 4487: 0.03%
Covered Lines: 22911
Relevant Lines: 81871

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #639 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #639      +/-   ##
===========================================
+ Coverage     25.48%   25.5%   +0.01%     
- Complexity     5892    5900       +8     
===========================================
  Files          1379    1379              
  Lines         81871   81871              
  Branches      11479   11479              
===========================================
+ Hits          20863   20878      +15     
+ Misses        58986   58964      -22     
- Partials       2022    2029       +7
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
...apache/kylin/engine/mr/common/HadoopCmdOutput.java 14.7% <0%> (+14.7%) 4% <0%> (+4%) ⬆️
...ylin/engine/mr/common/DefaultX509TrustManager.java 35.71% <0%> (+35.71%) 5% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39b238...4c5f7f1. Read the comment docs.

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 20fa8b1 into apache:master May 14, 2019
nichunen pushed a commit to nichunen/kylin that referenced this pull request May 16, 2019
* Add tests for DefaultX509TrustManager

* Added tests for HadoopCmdOutput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants