Skip to content

add overwrite method KafkaClient.getKafkaConsumer()#650

Closed
liuzx32 wants to merge 1 commit intoapache:masterfrom
liuzx32:master
Closed

add overwrite method KafkaClient.getKafkaConsumer()#650
liuzx32 wants to merge 1 commit intoapache:masterfrom
liuzx32:master

Conversation

@liuzx32
Copy link
Copy Markdown

@liuzx32 liuzx32 commented May 21, 2019

Description
Add an overwrite method getKafkaConsumer() for KafkaClient.

Improvement
Add method getKafkaConsumer() with the default properties from KafkaConsumerProperties.
The class KafkaConsumerProperties can load kafka config from conf/kylin-kafka-consumer.xml.

@asfgit
Copy link
Copy Markdown

asfgit commented May 21, 2019

Can one of the admins verify this patch?

@liuzx32
Copy link
Copy Markdown
Author

liuzx32 commented May 21, 2019

Can one of the admins verify this patch?

Yes, admins can check it.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #650 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #650     +/-   ##
==========================================
+ Coverage      25.7%   25.8%   +0.1%     
- Complexity     5976    6008     +32     
==========================================
  Files          1382    1382             
  Lines         82144   82146      +2     
  Branches      11509   11509             
==========================================
+ Hits          21112   21198     +86     
+ Misses        58985   58897     -88     
- Partials       2047    2051      +4
Impacted Files Coverage Δ Complexity Δ
...rg/apache/kylin/source/kafka/util/KafkaClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 82.53% <0%> (+0.79%) 18% <0%> (+1%) ⬆️
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0%> (+2.3%) 0% <0%> (ø) ⬇️
...rg/apache/kylin/storage/hybrid/HybridInstance.java 44.27% <0%> (+6.1%) 17% <0%> (+4%) ⬆️
.../java/org/apache/kylin/storage/StorageContext.java 30.1% <0%> (+30.1%) 10% <0%> (+10%) ⬆️
...kylin/storage/translate/FuzzyValueCombination.java 94.23% <0%> (+94.23%) 17% <0%> (+17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48de90...fa03795. Read the comment docs.

@liuzx32 liuzx32 closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants