add overwrite method KafkaClient.getKafkaConsumer()#650
Closed
liuzx32 wants to merge 1 commit intoapache:masterfrom
liuzx32:master
Closed
add overwrite method KafkaClient.getKafkaConsumer()#650liuzx32 wants to merge 1 commit intoapache:masterfrom liuzx32:master
liuzx32 wants to merge 1 commit intoapache:masterfrom
liuzx32:master
Conversation
|
Can one of the admins verify this patch? |
Author
Yes, admins can check it. |
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 25.7% 25.8% +0.1%
- Complexity 5976 6008 +32
==========================================
Files 1382 1382
Lines 82144 82146 +2
Branches 11509 11509
==========================================
+ Hits 21112 21198 +86
+ Misses 58985 58897 -88
- Partials 2047 2051 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an overwrite method getKafkaConsumer() for KafkaClient.
Improvement
Add method getKafkaConsumer() with the default properties from KafkaConsumerProperties.
The class KafkaConsumerProperties can load kafka config from conf/kylin-kafka-consumer.xml.