Skip to content

#KYLIN-4030, ResourceStore deleteResource by comparing timestamp may be failed#673

Merged
nichunen merged 1 commit intoapache:masterfrom
ZhengshuaiPENG:KYLIN-4030
Jun 19, 2019
Merged

#KYLIN-4030, ResourceStore deleteResource by comparing timestamp may be failed#673
nichunen merged 1 commit intoapache:masterfrom
ZhengshuaiPENG:KYLIN-4030

Conversation

@ZhengshuaiPENG
Copy link
Copy Markdown

@ZhengshuaiPENG ZhengshuaiPENG commented Jun 3, 2019

See #KYLIN-4030

@asfgit
Copy link
Copy Markdown

asfgit commented Jun 3, 2019

Can one of the admins verify this patch?

@ZhengshuaiPENG ZhengshuaiPENG changed the title #KYLIN-4030, Resource deleteResource by comparing timestamp may faile… #KYLIN-4030, ResourceStore deleteResource by comparing timestamp may be failed Jun 3, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@354f6de). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #673   +/-   ##
=========================================
  Coverage          ?   25.79%           
  Complexity        ?     6009           
=========================================
  Files             ?     1382           
  Lines             ?    82204           
  Branches          ?    11518           
=========================================
  Hits              ?    21203           
  Misses            ?    58953           
  Partials          ?     2048
Impacted Files Coverage Δ Complexity Δ
...apache/kylin/storage/hbase/HBaseResourceStore.java 0% <0%> (ø) 0 <0> (?)
...he/kylin/common/persistence/JDBCResourceStore.java 0% <0%> (ø) 0 <0> (?)
...he/kylin/common/persistence/HDFSResourceStore.java 18.51% <0%> (ø) 5 <0> (?)
...he/kylin/common/persistence/FileResourceStore.java 62.62% <100%> (ø) 28 <0> (?)
...apache/kylin/common/persistence/ResourceStore.java 73.05% <83.33%> (ø) 56 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354f6de...2dec22e. Read the comment docs.

Copy link
Copy Markdown

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit c3a1728 into apache:master Jun 19, 2019
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.79%. Comparing base (354f6de) to head (2dec22e).

Files with missing lines Patch % Lines
...he/kylin/common/persistence/HDFSResourceStore.java 0.00% 2 Missing ⚠️
...he/kylin/common/persistence/JDBCResourceStore.java 0.00% 2 Missing ⚠️
...apache/kylin/storage/hbase/HBaseResourceStore.java 0.00% 2 Missing ⚠️
...apache/kylin/common/persistence/ResourceStore.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #673      +/-   ##
============================================
+ Coverage     25.77%   25.79%   +0.01%     
  Complexity     6009     6009              
============================================
  Files          1382     1382              
  Lines         82194    82204      +10     
  Branches      11516    11518       +2     
============================================
+ Hits          21187    21203      +16     
+ Misses        58956    58953       -3     
+ Partials       2051     2048       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants