remove tableName.toUppderCase() for hbase table Name,#688
Closed
liuzx32 wants to merge 4 commits intoapache:master-hadoop3.1from
liuzx32:master-hadoop3.1
Closed
remove tableName.toUppderCase() for hbase table Name,#688liuzx32 wants to merge 4 commits intoapache:master-hadoop3.1from liuzx32:master-hadoop3.1
liuzx32 wants to merge 4 commits intoapache:master-hadoop3.1from
liuzx32:master-hadoop3.1
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
…ble name is case sensitive.
added 2 commits
June 17, 2019 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HBase is case sensitive，tableName.toUpperCase() will lead to the created table could not be found.
If my tableName of HBase is lowercase, kylin can't find the table created in the HFile generated step.
Improvement
just remove toUpperCase() for HBase tableName on master-hadoop3.1.