KYLIN-4055 cube quey and ad-hoc query return different meta info#715
Closed
javalife0312 wants to merge 1 commit intoapache:masterfrom
javalife0312:master
Closed
KYLIN-4055 cube quey and ad-hoc query return different meta info#715javalife0312 wants to merge 1 commit intoapache:masterfrom javalife0312:master
javalife0312 wants to merge 1 commit intoapache:masterfrom
javalife0312:master
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
===========================================
+ Coverage 25.7% 25.7% +<.01%
Complexity 6012 6012
===========================================
Files 1386 1386
Lines 82513 82515 +2
Branches 11568 11568
===========================================
+ Hits 21206 21209 +3
Misses 59262 59262
+ Partials 2045 2044 -1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 4663
💛 - Coveralls |
nichunen
reviewed
Jul 14, 2019
| // Fall back to default value | ||
| } | ||
|
|
||
| columnLabel = columnLabel.toUpperCase(Locale.ROOT); |
There was a problem hiding this comment.
Why do upper case convert here?
It seems that there is possibility "columnLabel" or "columnName" be null if SQLException caught.
|
Will be done by #823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when cube quey then jdbc meta is upper
when ad-hoc quey of presto then jdbc meta is lower
ResultSetMetaData::getColumnLabel
ResultSetMetaData::getColumnName