KYLIN-4067 optimize the kylin cube page loading mechanism.

[zhaojintaozhao]

KYLIN-4067 optimize the kylin cube page loading mechanism. Get all information of cubes only when adding a new cube.

[asfgit]

Can one of the admins verify this patch?

[luguosheng1314]

it's better to add a special API to check the duplicate cube name

[codecov-io]

Codecov Report

Merging #728 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #728      +/-   ##
============================================
- Coverage     25.78%   25.76%   -0.03%     
- Complexity     6038     6046       +8     
============================================
  Files          1392     1393       +1     
  Lines         82808    82969     +161     
  Branches      11603    11605       +2     
============================================
+ Hits          21355    21378      +23     
- Misses        59399    59537     +138     
  Partials       2054     2054

Impacted Files	Coverage Δ	Complexity Δ
...he/kylin/stream/core/metrics/StreamingMetrics.java	23.07% <0%> (-43.59%)	4% <0%> (ø)
...apache/kylin/dict/TrieDictionaryForestBuilder.java	88.88% <0%> (-4.94%)	23% <0%> (-1%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java	63.84% <0%> (-2.31%)	0% <0%> (ø)
...c/main/java/org/apache/kylin/cube/CubeManager.java	36.97% <0%> (-0.8%)	44% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java	81.74% <0%> (-0.8%)	17% <0%> (-1%)
...a/org/apache/kylin/rest/job/StorageCleanupJob.java	64.95% <0%> (-0.53%)	31% <0%> (ø)
...ain/java/org/apache/kylin/cube/model/CubeDesc.java	64.12% <0%> (-0.16%)	181% <0%> (ø)
.../java/org/apache/kylin/common/KylinConfigBase.java	12.84% <0%> (-0.08%)	42% <0%> (ø)
...ylin/metrics/lib/impl/AbstractActiveReservoir.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
...e/kylin/common/persistence/JDBCSqlQueryFormat.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
... and 33 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1927c...a1d2373. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 4806

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1249 unchanged lines in 35 files lost coverage.
• Overall coverage decreased (-0.02%) to 28.245%

---

Files with Coverage Reduction	New Missed Lines	%
source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaClient.java	1	0.0%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/StubReservoir.java	2	0.0%
core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceSQL.java	3	0.0%
core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForestBuilder.java	3	92.59%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/AbstractActiveReservoir.java	3	0.0%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/ActiveReservoirReporter.java	6	0.0%
source-kafka/src/main/java/org/apache/kylin/source/kafka/TimedJsonStreamParser.java	8	90.11%
core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java	11	70.32%
core-metrics/src/main/java/org/apache/kylin/metrics/property/QueryRPCPropertyEnum.java	13	0.0%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/InstantReservoir.java	13	0.0%

Totals
Change from base Build 4690:	-0.02%
Covered Lines:	23435
Relevant Lines:	82969

---

💛 - Coveralls

[zhaojintaozhao]

Pull Request Test Coverage Report for Build 4691

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.001%) to 28.271%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals
Change from base Build 4690: 0.001%
Covered Lines: 23411
Relevant Lines:

Pull Request Test Coverage Report for Build 4691

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.001%) to 28.271%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals
Change from base Build 4690: 0.001%
Covered Lines: 23411
Relevant Lines: 82808

💛 - Coveralls

I just modify js files, why the "Test Coverage Report for Build 4691" show tow java files reduce coverage ?

[zhaojintaozhao]

it's better to add a special API to check the duplicate cube name

Hi, Guosheng:
That's a good idea. I add a new API to check the duplicate cube name.
The main value of this PR is to speed up when open Kylin web page. If one project has more than 200 cubes, it loads very slowly when opening kylin cube page， even may open failure.

[nichunen]

$scope.cubeService seems never used

[zhaojintaozhao]

Hi， chunen：
Yes, "$scope.cubeService" never be used.
I will submit code to delete this line tonight.

[zhaojintaozhao]

Hi, chunen:
I have deleted this unused line: "$scope.cubeService = CubeService" and submit code.
Please verify this patch, Thank you.

[nichunen]

LGTM

[RupengWang]

LGTM