Skip to content

KYLIN-3901: Use multi threads to speed up the storage cleanup job#756

Merged
nichunen merged 1 commit intoapache:masterfrom
lshmouse:KYLIN-3901
Aug 26, 2019
Merged

KYLIN-3901: Use multi threads to speed up the storage cleanup job#756
nichunen merged 1 commit intoapache:masterfrom
lshmouse:KYLIN-3901

Conversation

@lshmouse
Copy link

See: https://issues.apache.org/jira/browse/KYLIN-3901

The pr only implement the multi-thread cleanup for hbase tables

@nichunen
Copy link

Hi @lshmouse Seems this pr has failed test cases

@lshmouse
Copy link
Author

@nichunen OK, let me fix the failed Tests.

@lshmouse
Copy link
Author

@nichunen The failed test is fixed and i will check the new ci results.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4939

  • 10 of 17 (58.82%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 28.086%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/job/StorageCleanJobHbaseUtil.java 2 4 50.0%
server-base/src/main/java/org/apache/kylin/rest/job/StorageCleanupJob.java 8 13 61.54%
Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 1 55.81%
Totals Coverage Status
Change from base Build 4935: 0.0%
Covered Lines: 23446
Relevant Lines: 83478

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit b78c088 into apache:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants