Skip to content

The table should not display in Insight page when the user has no acc…#789

Merged
nichunen merged 1 commit intoapache:masterfrom
zhangayqian:4034
Aug 27, 2019
Merged

The table should not display in Insight page when the user has no acc…#789
nichunen merged 1 commit intoapache:masterfrom
zhangayqian:4034

Conversation

@zhangayqian
Copy link
Copy Markdown
Contributor

The table should not display in Insight page when the user has no access to the table

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@40cab4f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #789   +/-   ##
=========================================
  Coverage          ?   25.75%           
  Complexity        ?     6047           
=========================================
  Files             ?     1393           
  Lines             ?    83013           
  Branches          ?    11615           
=========================================
  Hits              ?    21383           
  Misses            ?    59577           
  Partials          ?     2053
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/kylin/metadata/acl/TableACL.java 74.71% <0%> (ø) 11 <0> (?)
...va/org/apache/kylin/rest/service/QueryService.java 0% <0%> (ø) 0 <0> (?)
.../apache/kylin/rest/controller/QueryController.java 0% <0%> (ø) 0 <0> (?)
...org/apache/kylin/rest/service/TableACLService.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cab4f...f82b40a. Read the comment docs.

Copy link
Copy Markdown

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit 54c1acf into apache:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants