KYLIN-4122 Add kylin user and group manage modules#790
Merged
nichunen merged 1 commit intoapache:masterfrom Aug 15, 2019
Merged
KYLIN-4122 Add kylin user and group manage modules#790nichunen merged 1 commit intoapache:masterfrom
nichunen merged 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
Coverage ? 25.63%
Complexity ? 6049
=========================================
Files ? 1398
Lines ? 83418
Branches ? 11683
=========================================
Hits ? 21386
Misses ? 59975
Partials ? 2057
Continue to review full report at Codecov.
|
nichunen
reviewed
Aug 12, 2019
| @Qualifier("userGroupService") | ||
| private UserGroupService userGroupService; | ||
|
|
||
| private Pattern passwordPattern; |
There was a problem hiding this comment.
Inappropriate order for these variables
nichunen
requested changes
Aug 13, 2019
| @RequestMapping(value = "/{userName:.+}", method = { RequestMethod.POST }, produces = { "application/json" }) | ||
| @ResponseBody | ||
| @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN) | ||
| //do not use aclEvaluate, if thgetManagedUsersByFuzzMatchingere's no users and will come into init() and will call save. |
| List<ManagedUser> all = userService.listUsers(); | ||
| logger.info("All {} users", all.size()); | ||
| if (all.isEmpty() && ("testing".equals(System.getProperty(ACTIVE_PROFILES_NAME)) | ||
| || "custom".equals(System.getProperty(ACTIVE_PROFILES_NAME)))) { |
|
|
||
| } | ||
|
|
||
| public UserDetails loadUserByUsername(String username) { |
|
|
||
| import java.io.IOException; | ||
| import java.util.Collection; | ||
| import java.util.Iterator; |
| @JsonProperty | ||
| private long firstLoginFailedTime = 0L; | ||
|
|
||
| private static final int CHECK_TIME = 900000; //15 minutes |
| package org.apache.kylin.rest.service; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; |
| List<ManagedUser> userList = getKylinUserManager().list(); | ||
| return getManagedUsersByFuzzMatching(userName, isFuzzMatch, userList, null); | ||
| } | ||
| @Override |
There was a problem hiding this comment.
Blank line should be inserted between methods
| } | ||
| return groups; | ||
| } | ||
| public static boolean isAdmin() { |
There was a problem hiding this comment.
looks duplicate with BasicController.isAdmin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.