Skip to content

KYLIN-4114 Provided a self-contained docker image for Kylin#797

Merged
nichunen merged 1 commit intoapache:masterfrom
weibin0516:KYLIN-4114
Aug 27, 2019
Merged

KYLIN-4114 Provided a self-contained docker image for Kylin#797
nichunen merged 1 commit intoapache:masterfrom
weibin0516:KYLIN-4114

Conversation

@weibin0516
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 10, 2019

Codecov Report

Merging #797 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #797      +/-   ##
============================================
- Coverage     25.61%   25.61%   -0.01%     
  Complexity     6046     6046              
============================================
  Files          1398     1398              
  Lines         83449    83449              
  Branches      11685    11685              
============================================
- Hits          21378    21376       -2     
- Misses        60017    60019       +2     
  Partials       2054     2054
Impacted Files Coverage Δ Complexity Δ
...che/kylin/stream/core/storage/CheckPointStore.java 63.63% <0%> (-3.04%) 21% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (+0.3%) 7% <0%> (ø) ⬇️
...ream/core/storage/columnar/ColumnarStoreCache.java 51.16% <0%> (+2.32%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c1a85...6833856. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 10, 2019

Pull Request Test Coverage Report for Build 4933

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 28.077%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 4935: 0.0%
Covered Lines: 23434
Relevant Lines: 83464

💛 - Coveralls

@weibin0516 weibin0516 force-pushed the KYLIN-4114 branch 2 times, most recently from dcceb23 to 4692fbc Compare August 11, 2019 02:29
@hit-lacus
Copy link
Member

hit-lacus commented Aug 11, 2019

Thanks @weibin0516 , this looks cool, here a list for what I want to check.

For PoC

  • MapReduce Cubing
  • Spark Cubing
  • Segment Merge
  • NRT Streaming
  • Realtime OLAP

For Developer

  • Package from source
  • Integration test

Other Comments

  • I guess we may check if we could upload image to docker hub, thus user may simplely run it in one command. (For PoC purpose.)
  • Maybe we could build image in hierarchy way, thus we can switch between different hadoop distribution easily. And for PoC, we could provided a minimized image; for developer, we could add maven/nodejs.
  • Make sure all basic function works well.

RUN mkdir -p /data/hadoop

# setup hbase
RUN wget https://archive.apache.org/dist/hbase/1.1.2/hbase-1.1.2-bin.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget to use $HBASE_VERSION here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

```
After the package is complete, use the package in `/home/admin/kylin_sourcecode/dist` to start the Kylin service.

You can also run CI inside the container:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Integration test can not pass currently, please remove this, thank you.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@weibin0516
Copy link
Author

@hit-lacus , thanks for review, all functions except Integration test work fine work fine. In my opinion, Integration test is not necessarily needed, may be i will solve it in next pr.

@hit-lacus
Copy link
Member

Hi, @weibin0516

Did you update your PR? I cannot find kylin.sh start & kylin.sh streaming start anywhere.

@hit-lacus
Copy link
Member

hit-lacus commented Aug 16, 2019

Test Env

  • MacOS 10.14.4
  • Docker Desktop for Mac (Docker Engine: 18.09.2)

Start standalone docker container

docker run -d --rm \
-p 7070:7070 \
-p 8088:8088 \
-p 50070:50070 \
-p 8032:8032 \
-p 8042:8042 \
-p 60010:60010 \
codingforfun/apache-kylin-standalone

Attach to container

docker exec -it ${CONTAINER_ID} /bin/bash

Building Cube (Build/Refresh/Merge)

image

image

Near Realtime Streaming

image

Realtime OLAP

image

image

Known issue

image
image

  1. Nodemanager may be unhealthy because of lack of disk space.
    This may be fixed by docker image prune -h to reduce needless disk space.

  2. Container cannot restart successfully.

  3. Realtime OLAP building job cubing job throw NPE for some reasons(to be checked).

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Awesome! Looks good to me! Thank you weibin!

@weibin0516
Copy link
Author

@shaofengshi , thanks very much.

The image has been pushed to the docker hub without having to build locally.
Execute the following command to pull image:
```
docker pull codingforfun/apache-kylin-standalone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this?

@nichunen nichunen merged commit 6e1d48e into apache:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants