KYLIN-4131 Fix Broadcaster memory leak#799
Merged
nichunen merged 1 commit intoapache:masterfrom Aug 15, 2019
Merged
Conversation
Author
|
CI passed |
Wayne1c
force-pushed
the
fix_memory_leak
branch
from
50c4c3c to
60684f0
Compare
Wayne1c
force-pushed
the
fix_memory_leak
branch
from
60684f0 to
e1bbc95
Compare
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
=========================================
Coverage ? 25.72%
Complexity ? 6047
=========================================
Files ? 1394
Lines ? 83122
Branches ? 11635
=========================================
Hits ? 21383
Misses ? 59686
Partials ? 2053
Continue to review full report at Codecov.
|
hit-lacus
reviewed
Aug 13, 2019
|
|
||
| package org.apache.kylin.common; | ||
|
|
||
| public interface Closeable { |
Member
There was a problem hiding this comment.
In my view, I suggest use java.io.Closeable instead. This interface looks needless.
Author
There was a problem hiding this comment.
Because there is no IO operation and do not need throw IOException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.