Add JoinedFormatter for dynamic variables in where sentence#813
Merged
nichunen merged 2 commits intoapache:masterfrom Sep 12, 2019
liuzx32:master
Merged
Add JoinedFormatter for dynamic variables in where sentence#813nichunen merged 2 commits intoapache:masterfrom liuzx32:master
nichunen merged 2 commits intoapache:masterfrom
liuzx32:master
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
============================================
+ Coverage 25.61% 25.63% +0.02%
- Complexity 6048 6060 +12
============================================
Files 1398 1399 +1
Lines 83511 83566 +55
Branches 11699 11705 +6
============================================
+ Hits 21391 21423 +32
- Misses 60065 60087 +22
- Partials 2055 2056 +1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 4953
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The users can use ${START_DATE} and ${END_DATE} in where filter which in the WebUI.
And the dynamic variables ${START_DATE} and ${END_DATE} are from the building date of Cube.
Refer-issue: https://issues.apache.org/jira/browse/KYLIN-4156