Skip to content

KYLIN-4176 Filter the intermediate tables when loading table metadata from tree#853

Merged
shaofengshi merged 1 commit intoapache:masterfrom
wkh8011:master
Sep 29, 2019
Merged

KYLIN-4176 Filter the intermediate tables when loading table metadata from tree#853
shaofengshi merged 1 commit intoapache:masterfrom
wkh8011:master

Conversation

@wkh8011
Copy link

@wkh8011 wkh8011 commented Sep 23, 2019

Load table metadata from tree in 'Data Source' tab, then choose one database, you will find the intermediate tables are also loaded, But intermediate tables are the inner tables, which should not be showed to client, so I filter them in the kylin server.

@asf-ci
Copy link

asf-ci commented Sep 23, 2019

Can one of the admins verify this patch?

@wkh8011 wkh8011 changed the title KYLIN-4176 Filter the intermediate tables when loading table metadata from tree KYLIN-4176 Sep 23, 2019
@wkh8011 wkh8011 changed the title KYLIN-4176 KYLIN-4176 Filter the intermediate tables when loading table metadata from tree Sep 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #853 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #853      +/-   ##
============================================
+ Coverage     25.61%   25.61%   +<.01%     
  Complexity     6068     6068              
============================================
  Files          1399     1399              
  Lines         83654    83657       +3     
  Branches      11722    11723       +1     
============================================
+ Hits          21431    21432       +1     
- Misses        60165    60167       +2     
  Partials       2058     2058
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/kylin/rest/service/TableService.java 13.79% <0%> (-0.17%) 9 <0> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
...core/storage/columnar/GeneralColumnDataReader.java 94.73% <0%> (+5.26%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566ded8...bd76716. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5046

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 28.083%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/service/TableService.java 0 4 0.0%
Totals Coverage Status
Change from base Build 5041: 0.004%
Covered Lines: 23493
Relevant Lines: 83657

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thank you!

@shaofengshi shaofengshi merged commit 78db799 into apache:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants