Skip to content

fix KYLIN-4184 Real time OLAP query gets wrong result#867

Merged
nichunen merged 1 commit intoapache:masterfrom
ikids-star:SMaster-006
Oct 11, 2019
Merged

fix KYLIN-4184 Real time OLAP query gets wrong result#867
nichunen merged 1 commit intoapache:masterfrom
ikids-star:SMaster-006

Conversation

@ikids-star
Copy link

@asf-ci
Copy link

asf-ci commented Sep 30, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #867 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #867      +/-   ##
============================================
- Coverage     25.46%   25.45%   -0.01%     
  Complexity     6107     6107              
============================================
  Files          1410     1410              
  Lines         84919    84929      +10     
  Branches      11897    11902       +5     
============================================
- Hits          21622    21621       -1     
- Misses        61218    61227       +9     
- Partials       2079     2081       +2
Impacted Files Coverage Δ Complexity Δ
.../kylin/stream/core/storage/columnar/RawRecord.java 46.87% <0%> (-15.63%) 7 <0> (ø)
...am/core/storage/columnar/FragmentSearchResult.java 68.15% <100%> (+0.31%) 11 <0> (ø) ⬇️
...mnar/compress/RunLengthCompressedColumnReader.java 98.41% <100%> (ø) 10 <2> (ø) ⬇️
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-0.61%) 7% <0%> (ø)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 76.74% <0%> (+2.32%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e64c23...1917988. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5078

  • 4 of 16 (25.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 27.912%

Changes Missing Coverage Covered Lines Changed/Added Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/RawRecord.java 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/RawRecord.java 2 46.88%
Totals Coverage Status
Change from base Build 5075: -0.002%
Covered Lines: 23705
Relevant Lines: 84929

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit 10429e4 into apache:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants