Skip to content

Revert "KYLIN-4097: Throw exception when too many dict slice evictions in AppendTrieDictionary"#892

Merged
nichunen merged 1 commit intoapache:masterfrom
Sean-Gu:revert-760-KYLIN-4097
Oct 17, 2019
Merged

Revert "KYLIN-4097: Throw exception when too many dict slice evictions in AppendTrieDictionary"#892
nichunen merged 1 commit intoapache:masterfrom
Sean-Gu:revert-760-KYLIN-4097

Conversation

@Sean-Gu
Copy link

@Sean-Gu Sean-Gu commented Oct 17, 2019

Reverts #760 for now due to failure of regression test.

…s in AppendTrieDictionary"

This reverts commit aabf00e.
@asf-ci
Copy link

asf-ci commented Oct 17, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Oct 17, 2019

Can one of the admins verify this patch?

@nichunen nichunen merged commit fbe90c3 into apache:master Oct 17, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@aabf00e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #892   +/-   ##
=========================================
  Coverage          ?   25.45%           
  Complexity        ?     6107           
=========================================
  Files             ?     1410           
  Lines             ?    84932           
  Branches          ?    11903           
=========================================
  Hits              ?    21623           
  Misses            ?    61228           
  Partials          ?     2081
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.72% <ø> (ø) 42 <0> (?)
...va/org/apache/kylin/dict/AppendTrieDictionary.java 57.5% <100%> (ø) 13 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabf00e...38e76d3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5124

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 27.913%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 3 78.42%
core-dictionary/src/main/java/org/apache/kylin/dict/AppendTrieDictionary.java 4 65.0%
Totals Coverage Status
Change from base Build 5123: -0.01%
Covered Lines: 23707
Relevant Lines: 84932

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants