Skip to content

Fix disable a real time cube and then enable it ,this cube may can't submit build job anymore bug#898

Merged
nichunen merged 1 commit intoapache:masterfrom
wangxiaojing123:SMaster-009
Nov 29, 2019
Merged

Fix disable a real time cube and then enable it ,this cube may can't submit build job anymore bug#898
nichunen merged 1 commit intoapache:masterfrom
wangxiaojing123:SMaster-009

Conversation

@wangxiaojing123
Copy link

@codecov-io
Copy link

Codecov Report

Merging #898 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #898      +/-   ##
============================================
- Coverage     25.47%   25.45%   -0.02%     
+ Complexity     6110     6107       -3     
============================================
  Files          1410     1410              
  Lines         84932    84938       +6     
  Branches      11903    11905       +2     
============================================
- Hits          21636    21623      -13     
- Misses        61219    61233      +14     
- Partials       2077     2082       +5
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/kylin/rest/service/CubeService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-1.52%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe90c3...d46f325. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5138

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 27.912%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
Totals Coverage Status
Change from base Build 5126: -0.003%
Covered Lines: 23708
Relevant Lines: 84938

💛 - Coveralls

@hit-lacus
Copy link
Member

Look fine to me, and I will do a test in my env. Thank you!

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit daffe23 into apache:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants