Skip to content

KYLIN-4262 Fix pid in GC filename inconsistent with real pid#949

Merged
nichunen merged 1 commit intoapache:masterfrom
Wayne1c:KYLIN-4262
Nov 19, 2019
Merged

KYLIN-4262 Fix pid in GC filename inconsistent with real pid#949
nichunen merged 1 commit intoapache:masterfrom
Wayne1c:KYLIN-4262

Conversation

@Wayne1c
Copy link

@Wayne1c Wayne1c commented Nov 18, 2019

No description provided.

@asf-ci
Copy link

asf-ci commented Nov 18, 2019

Can one of the admins verify this patch?

@Wayne1c Wayne1c changed the title KYLIN-4246 Fix pid in GC filename inconsistent with real pid KYLIN-4262 Fix pid in GC filename inconsistent with real pid Nov 18, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #949 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
- Coverage     25.58%   25.56%   -0.02%     
+ Complexity     6140     6138       -2     
============================================
  Files          1412     1412              
  Lines         85072    85072              
  Branches      11928    11928              
============================================
- Hits          21762    21752      -10     
- Misses        61205    61211       +6     
- Partials       2105     2109       +4
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b853ce...28a4aaf. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 18, 2019

Pull Request Test Coverage Report for Build 5243

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 28.052%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 5229: -0.006%
Covered Lines: 23864
Relevant Lines: 85072

💛 - Coveralls

@Wayne1c
Copy link
Author

Wayne1c commented Nov 19, 2019

retest this please

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nichunen nichunen merged commit 6bbd1b3 into apache:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants