Skip to content

fix location change url error#966

Merged
nichunen merged 1 commit intoapache:masterfrom
Sean-Gu:KYLIN-1716
Dec 4, 2019
Merged

fix location change url error#966
nichunen merged 1 commit intoapache:masterfrom
Sean-Gu:KYLIN-1716

Conversation

@Sean-Gu
Copy link

@Sean-Gu Sean-Gu commented Nov 28, 2019

@asf-ci
Copy link

asf-ci commented Nov 28, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Nov 28, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #966 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #966      +/-   ##
============================================
- Coverage     25.46%   25.46%   -0.01%     
  Complexity     6139     6139              
============================================
  Files          1413     1413              
  Lines         85439    85439              
  Branches      11960    11960              
============================================
- Hits          21761    21756       -5     
- Misses        61571    61575       +4     
- Partials       2107     2108       +1
Impacted Files Coverage Δ Complexity Δ
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 78.37% <0%> (+5.4%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345e46c...f4440a6. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5301

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 27.935%

Files with Coverage Reduction New Missed Lines %
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals Coverage Status
Change from base Build 5300: -0.005%
Covered Lines: 23867
Relevant Lines: 85439

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nichunen nichunen merged commit 0a2786e into apache:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants