Skip to content

KYLIN-4260 When using server side PreparedStatement cache, the query …#969

Merged
nichunen merged 1 commit intoapache:masterfrom
mawu2:master
Dec 25, 2019
Merged

KYLIN-4260 When using server side PreparedStatement cache, the query …#969
nichunen merged 1 commit intoapache:masterfrom
mawu2:master

Conversation

@mawu2
Copy link

@mawu2 mawu2 commented Nov 30, 2019

…result are not match on TopN scenario

@asf-ci
Copy link

asf-ci commented Nov 30, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Nov 30, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #969 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #969      +/-   ##
============================================
- Coverage     25.49%   25.49%   -0.01%     
- Complexity     6146     6147       +1     
============================================
  Files          1413     1413              
  Lines         85451    85463      +12     
  Branches      11963    11968       +5     
============================================
+ Hits          21789    21791       +2     
- Misses        61544    61555      +11     
+ Partials       2118     2117       -1
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/kylin/query/relnode/OLAPContext.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/apache/kylin/metadata/realization/SQLDigest.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/apache/kylin/measure/topn/TopNMeasureType.java 3.98% <0%> (-0.04%) 3 <0> (ø)
...va/org/apache/kylin/rest/service/QueryService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../apache/kylin/query/enumerator/OLAPEnumerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-0.61%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 82.53% <0%> (+0.79%) 18% <0%> (+1%) ⬆️
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0%> (+2.3%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af5195...d496c12. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5306

  • 0 of 13 (0.0%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 27.978%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-metadata/src/main/java/org/apache/kylin/metadata/realization/SQLDigest.java 0 1 0.0%
query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java 0 1 0.0%
core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java 0 2 0.0%
query/src/main/java/org/apache/kylin/query/enumerator/OLAPEnumerator.java 0 2 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
query/src/main/java/org/apache/kylin/query/enumerator/OLAPEnumerator.java 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java 2 0.0%
Totals Coverage Status
Change from base Build 5305: -0.003%
Covered Lines: 23911
Relevant Lines: 85463

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit a7c78bc into apache:master Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants