Skip to content

KYLIN-4284:Introducing redis as a distributed cache for queries#981

Closed
zhangxiang17 wants to merge 3 commits intoapache:masterfrom
zhangxiang17:feature/redis-cache3
Closed

KYLIN-4284:Introducing redis as a distributed cache for queries#981
zhangxiang17 wants to merge 3 commits intoapache:masterfrom
zhangxiang17:feature/redis-cache3

Conversation

@zhangxiang17
Copy link

KYLIN-4284:Introducing redis as a distributed cache for queries

@asf-ci
Copy link

asf-ci commented Dec 9, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Dec 9, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@14603c3). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #981   +/-   ##
=========================================
  Coverage          ?   25.01%           
  Complexity        ?     6180           
=========================================
  Files             ?     1439           
  Lines             ?    87640           
  Branches          ?    12249           
=========================================
  Hits              ?    21919           
  Misses            ?    63568           
  Partials          ?     2153
Impacted Files Coverage Δ Complexity Δ
...e/kylin/cache/cachemanager/RemoteCacheManager.java 0% <0%> (ø) 0 <0> (?)
...n/cache/cachemanager/RedisCacheManagerAdaptor.java 0% <0%> (ø) 0 <0> (?)
...e/kylin/metadata/querymeta/SelectedColumnMeta.java 0% <0%> (ø) 0 <0> (?)
...ylin/cache/cachemanager/MemcachedCacheManager.java 43.33% <100%> (ø) 7 <1> (?)
.../cachemanager/RemoteLocalFailOverCacheManager.java 75% <50%> (ø) 7 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14603c3...f5a52bc. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5344

  • 7 of 18 (38.89%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 27.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cache/src/main/java/org/apache/kylin/cache/cachemanager/RemoteCacheManager.java 0 1 0.0%
cache/src/main/java/org/apache/kylin/cache/cachemanager/RedisCacheManagerAdaptor.java 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 3 78.42%
Totals Coverage Status
Change from base Build 5341: 0.008%
Covered Lines: 23980
Relevant Lines: 85891

💛 - Coveralls

@hit-lacus
Copy link
Member

Thank you @zhangxiang17, please give me some time, and I will do a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants