Reset the operation log before fetching new one#4067
Closed
turboFei wants to merge 4 commits intoapache:masterfrom
Closed
Reset the operation log before fetching new one#4067turboFei wants to merge 4 commits intoapache:masterfrom
turboFei wants to merge 4 commits intoapache:masterfrom
Conversation
turboFei
changed the title
ulysses-you
approved these changes
Jan 3, 2023
turboFei
changed the title
Contributor
|
thanks, merging to master/branch-1.6 |
ulysses-you
pushed a commit
that referenced
this pull request
Jan 4, 2023
### _Why are the changes needed?_ https://github.com/apache/kyuubi/blob/9342a29284234e21c73f96024a740c6e93e7cb33/kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala#L134-L141 We need to reset the operation log before fetching new operation log, otherwise, we might meet corner case. - The last operation log is not empty - we meet log not found exception - we can not terminate the loop because the `shouldFinishLog` is always false ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4067 from turboFei/check_status. Closes #4067 b61e14f [fwang12] style 5787ad9 [fwang12] do not fetch again 6dc479d [fwang12] refactor 37a9190 [fwang12] reset the log before fetch log Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org> (cherry picked from commit 2c6f17d) Signed-off-by: ulysses-you <ulyssesyou@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
kyuubi/kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
Lines 134 to 141 in 9342a29
We need to reset the operation log before fetching new operation log, otherwise, we might meet corner case.
shouldFinishLogis always falseHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request