Skip to content

[INFRA] Make all CI jobs run on ubuntu-22.04#4192

Closed
bowenliang123 wants to merge 1 commit intomasterfrom
ci-ubuntu-latest
Closed

[INFRA] Make all CI jobs run on ubuntu-22.04#4192
bowenliang123 wants to merge 1 commit intomasterfrom
ci-ubuntu-latest

Conversation

@bowenliang123
Copy link
Copy Markdown
Contributor

@bowenliang123 bowenliang123 commented Jan 19, 2023

Why are the changes needed?

In 21 CI workflow jobs, 18 run on ubuntu-22.04 and 3 run on ubuntu-latest (the same as ubuntu-22.04 currently),

Making all CI jobs run on ubuntu-22.04 to ensure alignment in the same operation system version, and it benefits from future version updates.

How was this patch tested?

CI actions pass.

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Jan 19, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #4192 (d57ec57) into master (b7efed9) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d57ec57 differs from pull request most recent head 8276c3a. Consider uploading reports for the commit 8276c3a to get more accurate results

@@             Coverage Diff              @@
##             master    #4192      +/-   ##
============================================
+ Coverage     52.98%   53.00%   +0.02%     
  Complexity       13       13              
============================================
  Files           548      548              
  Lines         29948    29948              
  Branches       4025     4025              
============================================
+ Hits          15867    15873       +6     
+ Misses        12602    12600       -2     
+ Partials       1479     1475       -4     
Impacted Files Coverage Δ
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) ⬇️
.../kyuubi/engine/spark/operation/ExecutePython.scala 81.46% <0.00%> (-0.87%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 80.24% <0.00%> (-0.62%) ⬇️
...org/apache/kyuubi/operation/ExecuteStatement.scala 77.92% <0.00%> (ø)
...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala 69.56% <0.00%> (+0.54%) ⬆️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 60.60% <0.00%> (+1.51%) ⬆️
...ache/kyuubi/operation/KyuubiOperationManager.scala 82.66% <0.00%> (+2.66%) ⬆️
.../apache/kyuubi/server/api/v1/BatchesResource.scala 71.78% <0.00%> (+2.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Jan 19, 2023

Thanks for finding this issue, but we prefer to use the explicit version, to avoid breaking changes on the "latest" tag changing to a new major version.

@bowenliang123 bowenliang123 changed the title [INFRA] make all CI jobs run on ubuntu-latest [INFRA] make all CI jobs run on ubuntu-22.04 Jan 19, 2023
@bowenliang123
Copy link
Copy Markdown
Contributor Author

Thanks for finding this issue, but we prefer to use the explicit version, to avoid breaking changes on the "latest" tag changing to a new major version.

Good suggestion, make all CI jobs running on ubuntu-22.04 instead.
ubuntu-22.04 is still the latest available runner for actions according to https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#choosing-github-hosted-runners .

@pan3793 pan3793 changed the title [INFRA] make all CI jobs run on ubuntu-22.04 [INFRA] Make all CI jobs run on ubuntu-22.04 Jan 19, 2023
@bowenliang123
Copy link
Copy Markdown
Contributor Author

thanks, merged to master.

@bowenliang123 bowenliang123 deleted the ci-ubuntu-latest branch January 19, 2023 15:36
@bowenliang123 bowenliang123 added this to the v1.7.0 milestone Jan 19, 2023
@bowenliang123 bowenliang123 self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:infra license, community building, project builds, asf infra related, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants